Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add full retrieval intent name #5432

Merged
merged 11 commits into from Mar 19, 2020
Merged

add full retrieval intent name #5432

merged 11 commits into from Mar 19, 2020

Conversation

indam23
Copy link
Contributor

@indam23 indam23 commented Mar 17, 2020 •
edited

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@indam23 indam23 linked an issue Mar 17, 2020 that may be closed by this pull request
Retrieval intent needs to store full intent name in tracker #4826
Closed
@indam23 indam23 changed the base branch from 1.8.x to master March 17, 2020 19:29
@indam23 indam23 requested a review from tabergma March 17, 2020 19:38
tabergma
tabergma requested changes Mar 18, 2020
View reviewed changes
Copy link
Contributor

@tabergma tabergma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like the idea 👍 However, I would propose to move the dictionary out of the DIETClassifier as it is only used in the ResponseSelector. Let's keep it in there. Left a couple of comments.

rasa/nlu/classifiers/diet_classifier.py Outdated Show resolved Hide resolved
rasa/nlu/selectors/response_selector.py Outdated Show resolved Hide resolved
rasa/nlu/selectors/response_selector.py Outdated Show resolved Hide resolved
rasa/nlu/classifiers/diet_classifier.py Outdated Show resolved Hide resolved
@indam23 indam23 requested a review from tabergma March 18, 2020 14:49
tabergma
tabergma requested changes Mar 18, 2020
View reviewed changes
Copy link
Contributor

@tabergma tabergma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should avoid code duplication. You can call the methods of the super class.

rasa/nlu/selectors/response_selector.py Outdated Show resolved Hide resolved
rasa/nlu/selectors/response_selector.py Outdated Show resolved Hide resolved
rasa/nlu/selectors/response_selector.py Show resolved Hide resolved
rasa/nlu/selectors/response_selector.py Outdated Show resolved Hide resolved
@tttthomasssss tttthomasssss added this to the Rasa 1.9 milestone Mar 18, 2020
@indam23
Copy link
Contributor Author

indam23 commented Mar 18, 2020

We should avoid code duplication. You can call the methods of the super class.

Did I do this right now? sorry, haven't worked with super() much

@indam23 indam23 requested a review from tabergma March 18, 2020 18:05
tabergma
tabergma approved these changes Mar 18, 2020
View reviewed changes
Copy link
Contributor

@tabergma tabergma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💯 Thanks for addressing all my comments 🚀

tests/nlu/selectors/test_selectors.py Outdated Show resolved Hide resolved
@indam23 indam23 merged commit ac8a0e2 into master Mar 19, 2020
@indam23 indam23 deleted the full_retrieval_intent branch March 19, 2020 22:45
@erohmensing erohmensing mentioned this pull request Mar 24, 2020
Closed
@indam23 indam23 mentioned this pull request Apr 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tabergma tabergma tabergma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Rasa 1.9
Development

Successfully merging this pull request may close these issues.

Retrieval intent needs to store full intent name in tracker
3 participants
@indam23 @tabergma @tttthomasssss